Skip to content

fix(sagemaker): Reduce number of reconnect retries #7827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sagemaker): Reduce number of reconnect retries #7827

wants to merge 1 commit into from
+2 −2

Conversation

NewtonDer
Copy link
Contributor

Problem

When a connection to a remote space is severed, the extension will attempt to reconnect up to 60 times. Each reconnect attempt opens the Space Details page in a new browser tab. Opening up to 60 new tabs is a poor user experience.

Solution

We change the maximum number of retries to 8.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@NewtonDer NewtonDer requested a review from a team as a code owner August 6, 2025 17:36
@amazon-inspector-ohio Amazon Inspector (Ohio)
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio Amazon Inspector (Ohio)
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leigaol leigaol leigaol approved these changes

@laileni-aws laileni-aws laileni-aws approved these changes

@aws-asolidu aws-asolidu aws-asolidu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewtonDer @leigaol @laileni-aws @aws-asolidu